Generate rules_java http_archive() instances from distdir_deps.bzl. #12787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a capability to generate WORKSPACE files for tests at build time, based on the repository definitions in distdir_deps.bzl. This makes it possible for the versions of repositories used in tests to align with the versions used a Bazel build time without upddating files scattered throughout the source and test trees. Demonstrated with rules_cc.
…srcs.tar This makes me think that the overall distfile build test is broken. You should be able to regenerate these files from the sources.
|
I expect the import CL will be somewhat painful because of copybara oddity. |
comius
approved these changes
Jan 8, 2021
|
Nice job! |
meteorcloudy
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This consolidates the specification of the rules_java we depend on into a single place. We generate
http_archive()stanzas for the main WORKSPACE as well as test harnesses from that, rather than keeping 3 instances in sync by hand. The old practice was error prone because you had to know about all the locations, and an update to one might not break the others immediately, but could be a lurking alignment problem.This continues the work on #12081.