Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move rules_proto and protocolbuffers/ubp to distdir_deps.bzl #12825

Closed
wants to merge 1 commit into from
Closed

Move rules_proto and protocolbuffers/ubp to distdir_deps.bzl #12825

wants to merge 1 commit into from

Conversation

aiuto
Copy link
Contributor

@aiuto aiuto commented Jan 13, 2021

  • generate @rules_proto workspace inclusions in shell tests
  • generate @rules_proto workspace inclusions in jdk.WORKSPACE
  • src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestEnvironment.java will be done in a future CL. That will be the first case where we need to generate Java code. It requires some design up front.

Context: #12081

@aiuto
Move rules_proto and protocolbuffers/ubp to distdir_deps.bzl
dfd6b97 
- generate @rules_proto workspace inclusions in tests
- src/test/java/com/google/devtools/build/lib/blackbox/framework/BlackBoxTestEnvironment.java will be done in a future CL. That will be the first case where we need to generate Java code. It requires some design up front.

Context: bazelbuild#12081
@google-cla google-cla bot added the cla: yes label Jan 13, 2021
@aiuto aiuto added the wip label Jan 13, 2021
@aiuto aiuto requested a review from meteorcloudy January 13, 2021 19:30
meteorcloudy
meteorcloudy approved these changes Jan 14, 2021
View reviewed changes
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in 320bc94 Jan 14, 2021
@aiuto aiuto deleted the proto_deps branch April 2, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

Assignees
No one assigned
Labels
cla: yes wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aiuto @meteorcloudy