Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs #13105

Closed
wants to merge 1 commit into from
Closed

[2/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs #13105

wants to merge 1 commit into from

Commits on Feb 25, 2021

  1. [2/3] Bump grpc to 1.33.1 to fix corruption when downloading CAS blobs 

    Part 2: Switch to grpc 1.33.1.

grpc-java versions 1.27 through 1.32 had a bug where messages could arrive
after the call was reported clsoed.  In the case of bazel, this meant that
in GrpcCacheClient, onNext could be called after onError.  This leads to
offset bookkeeping getting out of sync, and corrupts the CAS blob download.

bazelbuild#12927
    @scele
    scele committed Feb 25, 2021
    Configuration menu
    Copy the full SHA
    9adb25e View commit details
    Browse the repository at this point in the history