-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Bazel Coverage with C++ to work with Remote Execution #13232
Fix Bazel Coverage with C++ to work with Remote Execution #13232
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
src/main/java/com/google/devtools/build/lib/exec/StandaloneTestStrategy.java
Outdated
Show resolved
Hide resolved
ba84b37
to
c458e07
Compare
eaba210
to
835fdc1
Compare
9c1c605
to
dd36cf8
Compare
830f629
to
e97fab7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
e97fab7
to
400c3e4
Compare
Thanks a lot @finn-ball , great work! You are the only person so far that gave feedback about this feature. If at any point you think it's good enough, please let me know and I will remove the experimental flag. |
@oquenchil - Thanks for doing the initial work here. It's been a problem for a while. I would say that before you remove the experimental flags, you may want to check this out: |
Adds missing coverage files: #13193