Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bazel Coverage with C++ to work with Remote Execution #13232

Closed

Conversation

finn-ball
Copy link
Contributor

Adds missing coverage files: #13193

@google-cla
Copy link

google-cla bot commented Mar 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 16, 2021
@finn-ball
Copy link
Contributor Author

@googlebot I signed it!

@google-cla google-cla bot added cla: yes and removed cla: no labels Mar 16, 2021
@finn-ball finn-ball changed the title Adding a copy of the input files for coverage to consume with remote execution. Fix Bazel Coverage with C++ to work with Remote Execution Mar 16, 2021
@oquenchil oquenchil self-assigned this Mar 19, 2021
@finn-ball finn-ball force-pushed the finn/fix-re-cpp-cov branch 2 times, most recently from eaba210 to 835fdc1 Compare March 24, 2021 13:35
@finn-ball finn-ball force-pushed the finn/fix-re-cpp-cov branch 5 times, most recently from 9c1c605 to dd36cf8 Compare April 2, 2021 15:25
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oquenchil
Copy link
Contributor

Thanks a lot @finn-ball , great work!

You are the only person so far that gave feedback about this feature. If at any point you think it's good enough, please let me know and I will remove the experimental flag.

@finn-ball
Copy link
Contributor Author

@oquenchil - Thanks for doing the initial work here. It's been a problem for a while. I would say that before you remove the experimental flags, you may want to check this out:

#13185

philwo pushed a commit that referenced this pull request Apr 19, 2021
Adds missing coverage files: #13193

Closes #13232.

PiperOrigin-RevId: 367176195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants