Change set -x in coverage to be set by var
#13248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentleyjones
approved these changes
Mar 19, 2021
|
These scripts are quite broken in general. I found it very useful to leave these flags in when debugging what was going wrong with coverage. Out of curiosity, I see you also removed the |
|
We plan on using code coverage with remote execution, yes. For context, we are doing Swift code coverage, not C++. |
|
I definitely get the debugging use case, it's too bad we don't have an easy way to have both here. Maybe we can conditionally |
This causes logs to be very noisy with coverage infrastructure logic
keith
force-pushed
the
ks/remove-set-x-from-coverage-collection
branch
from
d583f14 to
64013e1
Compare
keith
changed the title
set -x in coverage to be set by var
|
@c-mita can you review? |
c-mita
approved these changes
Apr 20, 2021
|
Thanks! |
philwo
pushed a commit
that referenced
this pull request
Apr 20, 2021
Using `set -x` in the coverage scripts causes a lot of noise, this changes it to be off by default, but something you can enable by passing `--test_env=VERBOSE_COVERAGE=1` for debugging. Closes #13248. PiperOrigin-RevId: 369396233
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
set -xin the coverage scripts causes a lot of noise, this changes it to be off by default, but something you can enable by passing--test_env=VERBOSE_COVERAGE=1for debugging.