Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use provided stub_shebang when building with --build_python_zip #13468

Closed
wants to merge 1 commit into from
Closed

Conversation

stdbug
Copy link

@stdbug stdbug commented May 12, 2021

Use stub_shebang when building with --build_python_zip. Escapes single quotes within stub_shebang before passing it to echo

#8685

Tests (Debian 10):
$ bazelisk test //src/test/java/com/google/devtools/build/lib/rules/python/...:all
$ bazel test //src/test/java/com/google/devtools/build/lib/rules/python/...:all

@google-cla
Copy link

google-cla bot commented May 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 12, 2021
@stdbug
Copy link
Author

stdbug commented May 12, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented May 12, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@stdbug stdbug closed this May 12, 2021
@stdbug
Copy link
Author

stdbug commented May 12, 2021

Will reopen with signed user commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant