Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding TEMP_FAILURE_RETRY definition for musl #13483

Closed
wants to merge 1 commit into from
Closed

Adding TEMP_FAILURE_RETRY definition for musl #13483

wants to merge 1 commit into from

Conversation

foopub
Copy link

@foopub foopub commented May 17, 2021

Needed to compile under musl. Taken directly from glibc's unistd.h:
https://sourceware.org/git/?p=glibc.git;a=blob_plain;f=posix/unistd.h;hb=HEAD

@google-cla
Copy link

google-cla bot commented May 17, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label May 17, 2021
@foopub
Copy link
Author

foopub commented May 17, 2021

@philwo fix for #12460

@foopub
Copy link
Author

foopub commented May 17, 2021 via email

@google-cla google-cla bot added cla: yes and removed cla: no labels May 17, 2021
@philwo philwo self-assigned this May 17, 2021
@philwo philwo self-requested a review May 17, 2021 19:03
@aiuto
Copy link
Contributor

aiuto commented May 17, 2021

Is there an existing issue that this fixes?

@philwo
Copy link
Member

philwo commented May 18, 2021

@foopub Thanks! I need to clarify something internally first, but should get an answer today, I'll follow up here asap.

@philwo
Copy link
Member

philwo commented May 18, 2021

Hi @foopub, sorry for the delay. The problem is that we can't accept a patch that is copying or based on glibc's code due to licensing issues. I know it's just a small snippet, but we really want to be careful here and do the right thing. 😊

The good news is that I found an internal source for this macro in our Google repo and can just use that one instead. I'm sorry for the hassle and hope for your understanding!

I'll tag #12460 in my commit so you'll see when it's committed!

@philwo philwo closed this May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants