Use correct exit code on invalid aquery --output #13660
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this exits 0, which is dangerous - scripts may assume a query succeeded with no results, where actually it never ran. Instead, properly exit with exit code 2.
joeleba
approved these changes
Jul 21, 2021
|
Thanks for the PR! |
illicitonion
added a commit
to illicitonion/bazel
that referenced
this pull request
Jul 22, 2021
Currently this exits 0, which is dangerous - scripts may assume a query succeeded with no results, where actually it never ran. Instead, properly exit with exit code 2. Closes bazelbuild#13660. PiperOrigin-RevId: 385959603
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this exits 0, which is dangerous - scripts may assume a query
succeeded with no results, where actually it never ran.
Instead, properly exit with exit code 2.