Add authentication support to the downloader rewriter #13822
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The external repository downloader rewriter currently allows configuring bazel to pull external dependencies from alternative locations. However, it doesn't take credentials in the url into account. This change fixes that by reading the user information from the URL object and updating the authHeaders accordingly.
|
Just a friendly reminder :) |
coeuvre
approved these changes
Aug 20, 2021
| @@ -101,8 +102,11 @@ public Path download( | |||
| } | |||
|
|
|||
| List<URL> rewrittenUrls = originalUrls; | |||
| Map<URI, Map<String, String>> rewrittenAuthHeaders = ImmutableMap.copyOf(authHeaders); | |||
There was a problem hiding this comment.
nit: rewrittenAuthHeaders = authHeaders to save the copy?
There was a problem hiding this comment.
Please address this comment or I can do it during import if you don't mind.
There was a problem hiding this comment.
I will import the PR and address this during that. Thanks for the PR!
There was a problem hiding this comment.
Hey; sorry about that. I'm not super familiar with Github and I didn't receive these on the right email. Thanks a lot @keith for following up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The external repository downloader rewriter currently allows configuring
bazel to pull external dependencies from alternative locations. However,
it doesn't take credentials in the url into account.
This change fixes that by reading the user information from the URL
object and updating the authHeaders accordingly.