Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherrypick 4.2.1] Revert 80c59de in 4.2 branch #13893

Merged

Conversation

katre
Copy link
Member

@katre katre commented Aug 23, 2021

This fixes #13890 by reverting 80c59de in the 4.2 series.

@google-cla google-cla bot added the cla: yes label Aug 23, 2021
@katre katre requested a review from gregestren August 24, 2021 12:54
@gregestren
Copy link
Contributor

Is the bug saying that if we also had 98d376f then all would be well? So it's a patch sequencing error?

@katre
Copy link
Member Author

katre commented Aug 24, 2021

Yes, a bisect indicates that 98d376f should fix this, but I couldn't figure out a set of commits to cherrypick that gets it to apply cleanly. Since the original request to include 80c59de doesn't have any justification, I feel like it's reasonable to remove.

@katre katre merged commit ba86780 into bazelbuild:release-4.2.1-patches Aug 24, 2021
@katre katre mentioned this pull request Aug 24, 2021
9 tasks
@katre katre deleted the cp-4.2.1-i13890-flag-regression branch April 25, 2023 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants