Fix [Prepa] actions stuck in active state #14020
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UiStateTracker can process ActionProgress events after an ActionCompletion event has been fired. This has the effect of recreating the action object in the activeActions Map because Map.computeIfAbsent() is being used to retrieve the action. Therefore, a new method getActionStateIfPresent is created which will return the action if it exists, otherwise return null, and actionProgress() uses this method so as to not inadverntantly recreate actions after they have already completed and been removed from the Map.
coeuvre
approved these changes
Sep 22, 2021
bjacklyn
pushed a commit
to bjacklyn/bazel
that referenced
this pull request
Nov 24, 2021
Fixed bazelbuild#13985 UiStateTracker can process ActionProgress events after an ActionCompletion event has been fired. This has the effect of recreating the action object in the activeActions Map because Map.computeIfAbsent() is being used to retrieve the action. Therefore, a new method getActionStateIfPresent is created which will return the action if it exists, otherwise return null, and actionProgress() uses this method so as to not inadverntantly recreate actions after they have already completed and been removed from the Map. Closes bazelbuild#14020. PiperOrigin-RevId: 398165993 (cherry picked from commit 639f89d)
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 25, 2021
Fixed #13985 UiStateTracker can process ActionProgress events after an ActionCompletion event has been fired. This has the effect of recreating the action object in the activeActions Map because Map.computeIfAbsent() is being used to retrieve the action. Therefore, a new method getActionStateIfPresent is created which will return the action if it exists, otherwise return null, and actionProgress() uses this method so as to not inadverntantly recreate actions after they have already completed and been removed from the Map. Closes #14020. PiperOrigin-RevId: 398165993 (cherry picked from commit 639f89d) Co-authored-by: Brandon Jacklyn <brandonjacklyn@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #13985
UiStateTracker can process ActionProgress events after an ActionCompletion event
has been fired. This has the effect of recreating the action object in the activeActions
Map because Map.computeIfAbsent() is being used to retrieve the action.
Therefore, a new method getActionStateIfPresent is created which will return
the action if it exists, otherwise return null, and actionProgress() uses this
method so as to not inadverntantly recreate actions after they have already
completed and been removed from the Map.