Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid leaking ResourceShrinkerAction args between requests #14145

Conversation

Bencodes
Copy link
Contributor

Keeping the ResourceShrinkerAction options in a static field allows these options to leak between requests in a multiplex world.

@bazel-io bazel-io closed this in 9b5fcc6 Oct 25, 2021
copybara-service bot pushed a commit that referenced this pull request Jun 22, 2022
Adding support for multiplex workers inside of `ResourceProcessorBusyBox` and moving it's worker implementation over to the generic work request handler.

These PRs need to land for this to work:
- #14424
- #14425
- #14427

For those not on rolling releases, the other required PRs that have already merged are:
- #14144
- #14145
- #14146

Closes #14428.

PiperOrigin-RevId: 456561596
Change-Id: I098d5a323ac6558ad0f5f8190e29f45a7a37b4d4
aranguyen pushed a commit to aranguyen/bazel that referenced this pull request Jun 27, 2022
Adding support for multiplex workers inside of `ResourceProcessorBusyBox` and moving it's worker implementation over to the generic work request handler.

These PRs need to land for this to work:
- bazelbuild#14424
- bazelbuild#14425
- bazelbuild#14427

For those not on rolling releases, the other required PRs that have already merged are:
- bazelbuild#14144
- bazelbuild#14145
- bazelbuild#14146

Closes bazelbuild#14428.

PiperOrigin-RevId: 456561596
Change-Id: I098d5a323ac6558ad0f5f8190e29f45a7a37b4d4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant