Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.x] Add -no_uuid for hermetic macOS toolchain setup #14191

Conversation

keith
Copy link
Member

@keith keith commented Oct 28, 2021

The content based uuid embedded by ld64 contains the basename of the
file being built. In the case of multiarch builds this filename is
randomly generated. This doesn't hit in all cases based on the order of
the arguments to clang, but since this shouldn't have a downside for
this use case, it's safer to exclude this for the future.

More conversation #14168

Filed with apple as FB9727658

(cherry picked from commit d2aab87)

#14190

The content based uuid embedded by ld64 contains the basename of the
file being built. In the case of multiarch builds this filename is
randomly generated. This doesn't hit in all cases based on the order of
the arguments to clang, but since this shouldn't have a downside for
this use case, it's safer to exclude this for the future.

More conversation bazelbuild#14168

Filed with apple as FB9727658

(cherry picked from commit d2aab87)
@google-cla google-cla bot added the cla: yes label Oct 28, 2021
@Wyverald
Copy link
Member

I'll wait until #14190 is merged before merging this.

@oquenchil oquenchil self-assigned this Nov 2, 2021
@oquenchil oquenchil self-requested a review November 2, 2021 14:35
@oquenchil oquenchil added the team-Rules-CPP Issues for C++ rules label Nov 2, 2021
@brentleyjones
Copy link
Contributor

@Wyverald The main PR was merged, so this can be as well now 😃

@Wyverald Wyverald merged commit 2cf66f3 into bazelbuild:release-5.0.0rc1 Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants