Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocument --bes_best_effort #14333

Closed
wants to merge 4 commits into from
Closed

Undocument --bes_best_effort #14333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c29f883
Undocument --bes_best_effort
Yannic Nov 25, 2021
26b23f7
send it to graveyard
Yannic Dec 15, 2021
043ef9e
Merge branch 'master' into undocument_bes_best_effort
Yannic Jan 26, 2022
b472596
mv to AllCommandGraveyardOptions
Yannic Jan 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/main/java/com/google/devtools/build/lib/bazel/rules/BazelRulesModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,17 @@ public static final class AllCommandGraveyardOptions extends OptionsBase {
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
help = "No-op.")
public boolean incompatibleApplicableLicenses;

@Option(
name = "bes_best_effort",
defaultValue = "false",
deprecationWarning =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help = "No-op")
public boolean besBestEffort;
}

@Override
Expand Down
13 changes: 0 additions & 13 deletions src/main/java/com/google/devtools/build/lib/buildeventservice/BuildEventServiceOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,19 +65,6 @@ public class BuildEventServiceOptions extends OptionsBase {
allowMultiple = true)
public List<Map.Entry<String, String>> besHeaders;

@Option(
name = "bes_best_effort",
defaultValue = "false",
deprecationWarning =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.",
documentationCategory = OptionDocumentationCategory.LOGGING,
effectTags = {OptionEffectTag.AFFECTS_OUTPUTS},
help =
"BES best effort upload has been removed. The flag has no more "
+ "functionality attached to it and will be removed in a future release.")
public boolean besBestEffort;

@Option(
name = "bes_lifecycle_events",
defaultValue = "true",
Expand Down