-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apple] support watchos_arm64 in toolchain #14512
Conversation
"watchos_arm64": [ | ||
"@platforms//os:ios", | ||
"@platforms//cpu:aarch64", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if this will conflict with the one below or if there's a different CPU that should be used for one or the other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it may in the future. If the constraints are the same, toolchain resolution would pick this one first.
But, what is up with the name watchos_arm64_32?
That entry is strange with a name that implies 32 bits, while using aarch64.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
arm64_32 is a variant of arm64 with 32-bit pointer sizes, used on Apple Watch Series 4 and later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't sure about these. But ios_sim_arm64
and ios_arm64
are identical here too, so if it's wrong what's in here already is wrong.
cc @Wyverald @kaylathar I broke this out of that other PR (#14439). The |
This LGTM - no concerns |
@oquenchil or @Wyverald can you import? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really a review. I don't have enough knowledge of the Apple naming conventions.
"watchos_arm64": [ | ||
"@platforms//os:ios", | ||
"@platforms//cpu:aarch64", | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like it may in the future. If the constraints are the same, toolchain resolution would pick this one first.
But, what is up with the name watchos_arm64_32?
That entry is strange with a name that implies 32 bits, while using aarch64.
I'll do the import. |
@katre asks:
|
I don't think this change should change those, as that's a much larger and riskier change for this current addition. |
Someone should investigate these, but I don't know enough about the difference between the ios variants to know what's correct. |
The watch-only changes from bazelbuild#14439 Closes bazelbuild#14512. PiperOrigin-RevId: 420296580 (cherry picked from commit b341802)
The watch-only changes from #14439