Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uses of std++ on bsd #14668

Closed
wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Jan 29, 2022

This fix is the same as #14542
but for freebsd and openbsd

Hopefully fixes bazelbuild/rules_rust#978

This fix is the same as bazelbuild#14542
but for freebsd and openbsd
@keith
Copy link
Member Author

keith commented Jan 29, 2022

@uhthomas can you test this change to see if it fixes bazelbuild/rules_rust#978 for you?

@uhthomas
Copy link
Contributor

uhthomas commented Feb 3, 2022

Thanks for submitting this @keith! It might be worth asking some of the original commenters on rules_rust as I don't have any bsd systems at current, sorry.

@oquenchil oquenchil self-requested a review February 16, 2022 14:54
Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brentleyjones
Copy link
Contributor

@bazel-io fork 5.1

@bazel-io bazel-io closed this in a987b98 Feb 17, 2022
brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Feb 17, 2022
This fix is the same as bazelbuild#14542
but for freebsd and openbsd

Hopefully fixes bazelbuild/rules_rust#978

Closes bazelbuild#14668.

PiperOrigin-RevId: 429354084
(cherry picked from commit a987b98)
Wyverald pushed a commit that referenced this pull request Feb 17, 2022
This fix is the same as #14542
but for freebsd and openbsd

Hopefully fixes bazelbuild/rules_rust#978

Closes #14668.

PiperOrigin-RevId: 429354084
(cherry picked from commit a987b98)

Co-authored-by: Keith Smiley <keithbsmiley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FreeBSD] ld: error: unable to find library -lstdc++
5 participants