Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Apple crosstool to return a complete target triple that includes minimum OS version and target environment #14898

Conversation

thii
Copy link
Member

@thii thii commented Feb 24, 2022

This is required for bazelbuild/rules_swift#768

includes minimum OS version and target environment

This is required for bazelbuild/rules_swift#768
@thii thii marked this pull request as ready for review February 24, 2022 07:01
Copy link
Member

@keith keith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this matches what xcode does today

@keith
Copy link
Member

keith commented Mar 3, 2022

cc @oquenchil can you review?

@oquenchil oquenchil added platform: apple team-Rules-ObjC Issues for Objective-C maintainers labels Mar 10, 2022
@thii
Copy link
Member Author

thii commented Mar 24, 2022

@googlewalt Can you review?

@bazel-io bazel-io closed this in 3442179 Mar 28, 2022
@brentleyjones
Copy link
Contributor

@bazel-io fork 5.2

@thii thii deleted the configure-apple-crosstool-to-return-a-complete-target-triple-that branch March 29, 2022 00:35
thii added a commit to thii/bazel that referenced this pull request Apr 15, 2022
…ludes minimum OS version and target environment

This is required for bazelbuild/rules_swift#768

Closes bazelbuild#14898.

PiperOrigin-RevId: 437770046
(cherry picked from commit 3442179)
thii added a commit to thii/bazel that referenced this pull request Apr 18, 2022
…ludes minimum OS version and target environment

This is required for bazelbuild/rules_swift#768

Closes bazelbuild#14898.

PiperOrigin-RevId: 437770046
(cherry picked from commit 3442179)
ckolli5 pushed a commit that referenced this pull request May 9, 2022
…ludes minimum OS version and target environment (#15266)

This is required for bazelbuild/rules_swift#768

Closes #14898.

PiperOrigin-RevId: 437770046
(cherry picked from commit 3442179)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform: apple team-Rules-ObjC Issues for Objective-C maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants