Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make protocOpts() public. #14952

Merged
merged 4 commits into from
Mar 4, 2022
Merged

Make protocOpts() public. #14952

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
99d3d96
Make protocOpts() public.
a-googler Feb 24, 2022
a677415
Cleanup
comius Mar 4, 2022
b32b304
Add import.
comius Mar 4, 2022
68854aa
Add the right import.
comius Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/main/java/com/google/devtools/build/lib/rules/proto/ProtoConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,7 @@ public ProtoConfiguration(BuildOptions buildOptions) {
this.options = options;
}

@StarlarkMethod(name = "experimental_protoc_opts", structField = true, documented = false)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs import for StarlarkMethod, it looks like

public ImmutableList<String> protocOpts() {
return protocOpts;
}
Expand Down