Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not hide BulkTransferException messages when there were more than one exception #14981

Conversation

thii
Copy link
Member

@thii thii commented Mar 7, 2022

Previously, when there were more than one BulkTransferException, it
would be reported like this:

Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer

which didn't include the underlying exception messages. The only case
that underlying exceptions were included was when there was only one
exception.

This change patches the error message to include all the exception
messages, which helps diagnose BulkTransferException.

exception

Previously, when there were more than one BulkTransferException, it
would be reported like this:

```
Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer
```

which didn't include the underlying exception messages. The only case
that underlying exceptions were included was when there was only one
exception.

This change patches the error message to include all the exception
messages, which helps diagnose BulkTransferException.
@thii thii force-pushed the do-not-hide-bulktransferexception-messages-when-there-were-more-than-one branch from 158f4f9 to 8c1b84c Compare March 7, 2022 09:24
@thii thii marked this pull request as ready for review March 7, 2022 09:38
@thii thii requested a review from a team as a code owner March 7, 2022 09:38
@bazel-io bazel-io closed this in 113eaca Mar 7, 2022
@thii thii deleted the do-not-hide-bulktransferexception-messages-when-there-were-more-than-one branch March 7, 2022 13:58
@brentleyjones
Copy link
Contributor

@bazel-io fork 5.1

brentleyjones pushed a commit to brentleyjones/bazel that referenced this pull request Mar 7, 2022
…one exception

Previously, when there were more than one BulkTransferException, it
would be reported like this:

```
Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer
```

which didn't include the underlying exception messages. The only case
that underlying exceptions were included was when there was only one
exception.

This change patches the error message to include all the exception
messages, which helps diagnose BulkTransferException.

Closes bazelbuild#14981.

PiperOrigin-RevId: 432921283
(cherry picked from commit 113eaca)
Wyverald pushed a commit that referenced this pull request Mar 7, 2022
…one exception (#14986)

Previously, when there were more than one BulkTransferException, it
would be reported like this:

```
Executing genrule //:foo failed: Exec failed due to IOException: 221 errors during bulk transfer
```

which didn't include the underlying exception messages. The only case
that underlying exceptions were included was when there was only one
exception.

This change patches the error message to include all the exception
messages, which helps diagnose BulkTransferException.

Closes #14981.

PiperOrigin-RevId: 432921283
(cherry picked from commit 113eaca)

Co-authored-by: Thi Doan <t@thi.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants