Fix ZipDecompressor windows 0x80 (file attribute normal) #15260
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
the
team-ExternalDeps
meteorcloudy
requested changes
Apr 19, 2022
src/main/java/com/google/devtools/build/lib/bazel/repository/ZipDecompressor.java
Outdated
Show resolved
Hide resolved
meteorcloudy
added
the
awaiting-user-response
meteorcloudy
approved these changes
Apr 19, 2022
Juh-Roch
pushed a commit
to Juh-Roch/bazel
that referenced
this pull request
Jul 18, 2022
Fixes bazelbuild#9236. On a rare occasion a zip file contains files with the 0x80 attribute. From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants A file that does not have other attributes set. This attribute is valid only when used alone. Closes bazelbuild#15260. PiperOrigin-RevId: 442825326 (cherry picked from commit aa2a1f3)
ckolli5
added a commit
that referenced
this pull request
Jul 19, 2022
Fixes #9236. On a rare occasion a zip file contains files with the 0x80 attribute. From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants A file that does not have other attributes set. This attribute is valid only when used alone. Closes #15260. PiperOrigin-RevId: 442825326 (cherry picked from commit aa2a1f3) Co-authored-by: Tom de Goede <tom.degoede@afas.nl> Co-authored-by: Chenchu K <ckolli@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9236. On a rare occasion a zip file contains files with the 0x80 attribute.
From https://docs.microsoft.com/en-us/windows/win32/fileio/file-attribute-constants
A file that does not have other attributes set. This attribute is valid only when used alone.