Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix downloading remote execution output files inside output dirs. #15329

Closed
wants to merge 1 commit into from
Closed

Fix downloading remote execution output files inside output dirs. #15329

wants to merge 1 commit into from

Conversation

jmillikin
Copy link
Contributor

Adds a check to prevent creating multiple download futures for output files that are children of output directories.

Fixes #15328

@jmillikin jmillikin requested a review from a team as a code owner April 24, 2022 13:47
@sgowroji sgowroji added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Apr 25, 2022
coeuvre
coeuvre approved these changes Apr 26, 2022
View reviewed changes
Copy link
Member

@coeuvre coeuvre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bazel-io bazel-io closed this in ff6ac53 Apr 26, 2022
@brentleyjones
Copy link
Contributor

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 26, 2022
This was referenced Apr 27, 2022
Closed
Closed
@ckolli5
Copy link

ckolli5 commented Apr 27, 2022

@bazel-io fork 5.2.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Apr 27, 2022
@bazel-io bazel-io mentioned this pull request Apr 27, 2022
Closed
@ckolli5 ckolli5 mentioned this pull request May 10, 2022
Merged
ckolli5 added a commit that referenced this pull request May 10, 2022
@ckolli5 @jmillikin
Fix downloading remote execution output files inside output dirs. (#1…
b2dfb4a 
…5444)

Adds a check to prevent creating multiple download futures for output files that are children of output directories.

Fixes #15328

Closes #15329.

PiperOrigin-RevId: 444542026

Co-authored-by: John Millikin <john@john-millikin.com>
meteorcloudy pushed a commit that referenced this pull request May 10, 2022
@ckolli5 @jmillikin @meteorcloudy
Fix downloading remote execution output files inside output dirs. (#1…
652b48e 
…5444)

Adds a check to prevent creating multiple download futures for output files that are children of output directories.

Fixes #15328

Closes #15329.

PiperOrigin-RevId: 444542026

Co-authored-by: John Millikin <john@john-millikin.com>
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
@jmillikin jmillikin deleted the dedupe-cas-downloads branch September 18, 2022 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coeuvre coeuvre coeuvre approved these changes

Assignees
No one assigned
Labels
team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File output inside directory output fails to download from remote cache
7 participants
@jmillikin @brentleyjones @ckolli5 @coeuvre @bazel-io @sgowroji @ShreeM01