-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to produce serialized diagnostics files #15403
Add feature to produce serialized diagnostics files #15403
Conversation
3fb225c
to
49683e2
Compare
@googlewalt Do you think you are the right person to review this? @oquenchil Since this feature seems not only apply to objc rules, maybe you should also take a look? |
Hi Brentley, through no fault of your own this involves a lot of piping in the codebase just to tell Bazel about a new file being produced during compilation. Can you think of a way this could work using additional outputs?. I would already consider it a win if we don't have to know about that additional extension. Thanks. |
Sure, I'll take a look today to see if I can use that. |
From the looks of it, that will shift a small amount of code from Because of it being a |
49683e2
to
8a92ade
Compare
Using the `serialized_diagnostics_file` feature will add the `--serialized-diagnostics` flag to C/C++/Objective-C/Objective-C++ compiles, causing a declared`.dia` file output to be produced.
8a92ade
to
125f563
Compare
Friendly ping @oquenchil. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks @oquenchil. Can I get this imported? |
Using the
serialized_diagnostics_file
feature will add the--serialized-diagnostics
flag to C/C++/Objective-C/Objective-C++ compiles, causing a declared.dia
file output to be produced.Closes #15191.