Revert "Fixes incorrect install names on darwin platforms" #15450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b06f495. Also had to add a missing mnemonic function call parameter to `getDynamicLibrarySoname`. Copy-pasted the parameter from the other use of that function in the codebase. Tested manually with a custom toolchain and there is also a test from the reverted code. Fixes #15214 Closes #15261. PiperOrigin-RevId: 446662219
meteorcloudy
pushed a commit
that referenced
this pull request
May 10, 2022
This reverts commit b06f495. Also had to add a missing mnemonic function call parameter to `getDynamicLibrarySoname`. Copy-pasted the parameter from the other use of that function in the codebase. Tested manually with a custom toolchain and there is also a test from the reverted code. Fixes #15214 Closes #15261. PiperOrigin-RevId: 446662219 Co-authored-by: Chris Clearwater <chris@clearwater.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b06f495.
Also had to add a missing mnemonic function call parameter to
getDynamicLibrarySoname. Copy-pasted the parameter from the other use of that function in the codebase.Tested manually with a custom toolchain and there is also a test from the reverted code.
Fixes #15214
Closes #15261.
PiperOrigin-RevId: 446662219