Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a flag to force Bazel to download certain artifacts when using --remote_download_minimal #15638

Closed
wants to merge 11 commits into from
Closed

Add a flag to force Bazel to download certain artifacts when using --remote_download_minimal #15638

wants to merge 11 commits into from

Commits on Jun 8, 2022

  1. Add a flag to force Bazel to download certain artifacts 

    When using --remote_download_minimal Bazel only downloads to the client the minimum number of artifacts necessary for the build to succeed. This can be sometimes problematic when local development (i.e. IDE) requires some artifacts to do local work (e.g. syntax completion). We add a flag --experimental_force_downloads_regex that allow specifying a regular expression that will force certain artifacts to be forced to downloaded.

Tested locally that syntax errors disappear in IntelliJ when compiling Bazel itself with --remote_download_minimal and --experimental_force_downloads_regex=".*jar$", also included an integration test with several cases.

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    1cc9731 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2022

  1. Address most comments 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1fa3b54 View commit details
    Browse the repository at this point in the history

  2. Unify builders 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    1e6ea20 View commit details
    Browse the repository at this point in the history

  3. Revert and push green version 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jun 14, 2022
    Configuration menu
    Copy the full SHA
    01a26a4 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2022

  1. Merge https://github.com/bazelbuild/bazel into lfpino-bazel-forced-do… 

    …wnloads

Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    eefb0cd View commit details
    Browse the repository at this point in the history

  2. Move tests 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    ecc33b9 View commit details
    Browse the repository at this point in the history

  3. Address comments 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    4fef106 View commit details
    Browse the repository at this point in the history

  4. Address comments bazelbuild#2 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 5, 2022
    Configuration menu
    Copy the full SHA
    987d387 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. Debug 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    fdf3b25 View commit details
    Browse the repository at this point in the history

  2. Address comments bazelbuild#3 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    df6de24 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Address comments 

    Signed-off-by: Luis Fernando Pino Duque <luis@engflow.com>
    @lfpino
    lfpino committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    73fd192 View commit details
    Browse the repository at this point in the history