Throw explicit exception if experimental_split_coverage_postprocessing is used without experimental_fetch_all_coverage_outputs #16140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blindpirate
force-pushed
the
fix-experimental_split_coverage_postprocessing
branch
3 times, most recently
from
2b2d3e1
to
cb69580
Compare
sgowroji
added
team-Rules-CPP
|
Hello @blindpirate, Can you please check build failures. Thank you! |
|
@sgowroji The failure seems to be because CI machine is disconnected from Internet, can you give me some hints how to handle external dependencies which need to be downloaded in integration tests? |
sgowroji
added
awaiting-review
oquenchil
added
awaiting-PR-merge
|
Hello @oquenchil, Could you please guide on the above buildkite check failures. Thanks! |
gtech-bazel-bot
bot
added
the
awaiting-review
|
Adding @c-mita |
sgowroji
removed
the
awaiting-review
c-mita
requested changes
Oct 4, 2022
| #include "hello-greet.h" | ||
|
|
||
| TEST(HelloTest, GetGreet) { | ||
| EXPECT_EQ(get_greet("Bazel"), "Hello Bazel"); |
There was a problem hiding this comment.
This could just be return 0; or something - the actual test result doesn't matter, and we don't want to try pulling in gtest.
| @@ -111,13 +111,10 @@ public TestRunnerSpawn createTestRunnerSpawn( | |||
| throws ExecException, InterruptedException { | |||
| if (action.getExecutionSettings().getInputManifest() == null) { | |||
| String errorMessage = "cannot run local tests with --nobuild_runfile_manifests"; | |||
There was a problem hiding this comment.
Can remove this now unused local variable.
Comment on lines
918
to
935
| cat << EOF > hello-greet.h | ||
| #ifndef LIB_HELLO_GREET_H_ | ||
| #define LIB_HELLO_GREET_H_ | ||
|
|
||
| #include <string> | ||
|
|
||
| std::string get_greet(const std::string &thing); | ||
|
|
||
| #endif | ||
| EOF | ||
|
|
||
| cat << EOF > hello-greet.cc | ||
| #include <string> | ||
|
|
||
| std::string get_greet(const std::string& who) { | ||
| return "Hello " + who; | ||
| } | ||
| EOF |
There was a problem hiding this comment.
If you actually want a file under test, there's no need to make it complicated; a simple int foo() { return 42; } is more than sufficient here; we really don't care about the coverage reports, only that the flag combination raises an error,
sgowroji
added
awaiting-review
blindpirate
force-pushed
the
fix-experimental_split_coverage_postprocessing
branch
from
cb69580
to
bd105cb
Compare
…g is used without experimental_fetch_all_coverage_outputs This closes bazelbuild#13185 According to bazelbuild@a445cda, The flag --experimental_split_coverage_postprocessing depends on the flag --experimental_fetch_all_coverage_outputs being enabled, but if the former one is set without the latter one, Bazel throws a quite confusing NullPointerException. Now we throw an explicit exception with proper error message.
blindpirate
force-pushed
the
fix-experimental_split_coverage_postprocessing
branch
from
bd105cb
to
73a8d6c
Compare
|
Hi @sgowroji @oquenchil @c-mita now it's all green, PTAL! |
|
Thank you @blindpirate ! |
sgowroji
removed
the
awaiting-review
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
…g is used without experimental_fetch_all_coverage_outputs This closes bazelbuild#13185 According to bazelbuild@e411fa7, The flag --experimental_split_coverage_postprocessing depends on the flag --experimental_fetch_all_coverage_outputs being enabled, but if the former one is set without the latter one, Bazel throws a quite confusing NullPointerException. Now we throw an explicit exception with proper error message. Closes bazelbuild#16140. PiperOrigin-RevId: 479239693 Change-Id: I5afa0ae14a3f34a0a7b21fbf4badad3d1836da95
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #13185
According to e411fa7,
The flag --experimental_split_coverage_postprocessing depends on the flag
--experimental_fetch_all_coverage_outputs being enabled, but if the former one
is set without the latter one, Bazel throws a quite confusing NullPointerException.
Now we throw an explicit exception with proper error message.