Verify that incompatible options are preserved in the exec cfg #16449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding incompatible options is error-prone as adding them to their corresponding `FragmentOption`'s `getHost` method is easily forgotten. In that case, the flag will have no effect in the exec configuration, which has already caused very surprising, buggy behavior in numerous cases. This commit adds a test to verify that all non-deprecated incompatible flags: 1. are tagged with the `INCOMPATIBLE_CHANGE` metadata tag; 2. are preserved in the exec configuration. Fixes bazelbuild#12238 Fixes bazelbuild#16388
fmeum
force-pushed
the
16388-preserve-incompatible-options-in-exec
branch
from
945dcce
to
ba8b7f2
Compare
|
@gregestren Could you review? I grew tired of fixing these one-by-one ;-) |
sgowroji
added
team-Rules-Python
|
@sgowroji This ends up fixing Python issues along the way, but the root cause doesn't lie in rule logic. I expect the configurability team (e.g. @gregestren) to be in a better position to review this. |
sgowroji
added
the
team-Configurability
gregestren
approved these changes
Oct 12, 2022
gregestren
added
awaiting-PR-merge
sgowroji
removed
the
awaiting-PR-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding incompatible options is error-prone as it is easy to forget to add them to their corresponding
FragmentOption'sgetHostmethod. If this is not done, the flag will have no effect in the exec configuration, which has already caused very surprising, buggy behavior in numerous cases.This commit adds a test to verify that all non-deprecated incompatible flags:
INCOMPATIBLE_CHANGEmetadata tag;Fixes #12238
Fixes #16388