Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query command suggestion in error message with repo mappings #16482

Closed
wants to merge 1 commit into from
Closed

Fix query command suggestion in error message with repo mappings #16482

wants to merge 1 commit into from

Commits on Oct 19, 2022

  1. Fix query command suggestion in error message with repo mappings 

    The package label in the query command suggested when a specified target
isn't found in a package looked like `@rules_cc~1.0.0//pkg`, which
doesn't work with Bzlmod as the repo name is canonical, but the label
isn't.

This is fixed by introducing a new function `getDisplayForm` on
`PackageIdentifier` that prints the most readable label representation
of a package from the context of the main repository given a repository
mapping (ideally that of the main repository).

This function will be used in a follow-up PR to decanonicalize labels in
{a,c,}query output when possible.
    @fmeum
    fmeum committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    eaa63e5 View commit details
    Browse the repository at this point in the history