Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0] Emit Tree objects in topological order #16904

Merged
merged 2 commits into from
Dec 2, 2022

Commits on Dec 1, 2022

  1. Emit Tree objects in topological order

    remote-apis PR 230 added a way where producers of Tree messages can    indicate that the directories contained within are stored in topological    order. The advantage of using such an ordering is that it permits    instantiation of such objects onto a local file system in a streaming    fashion. The same holds for lookups of individual paths.
    
    Even though Bazel currently does not gain from this, this change at    least modifies Bazel's REv2 client to emit topologically sorted trees.    This makes it possible for tools such as Buildbarn's bb-browser to    process them more efficiently.
    
    More details:
    - bazelbuild/remote-apis#229
    - bazelbuild/remote-apis#230
    
    Closes #16463.
    
    PiperOrigin-RevId: 487196375
    Change-Id: Iafcfd617fc101fec7bfa943552113ce57ab8041b
    EdSchouten authored and ShreeM01 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    554053a View commit details
    Browse the repository at this point in the history
  2. Emit Tree objects in topological order

    remote-apis PR 230 added a way where producers of Tree messages can
    indicate that the directories contained within are stored in topological
    order. The advantage of using such an ordering is that it permits
    instantiation of such objects onto a local file system in a streaming
    fashion. The same holds for lookups of individual paths.
    
    Even though Bazel currently does not gain from this, this change at
    least modifies Bazel's REv2 client to emit topologically sorted trees.
    This makes it possible for tools such as Buildbarn's bb-browser to
    process them more efficiently.
    
    More details:
    - bazelbuild/remote-apis#229
    - bazelbuild/remote-apis#230
    
    Partial commit for third_party/*, see #16463.
    
    Signed-off-by: Sunil Gowroji <sgowroji@google.com>
    EdSchouten authored and ShreeM01 committed Dec 1, 2022
    Configuration menu
    Copy the full SHA
    d444570 View commit details
    Browse the repository at this point in the history