Always emit trailing zero in human-readable download progress #16950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coeuvre
approved these changes
Dec 7, 2022
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
coeuvre
added
the
awaiting-PR-merge
fmeum
force-pushed
the
improve-download-progress-format
branch
from
1bbd2d0
to
93b9a02
Compare
The human-readable download progress (e.g. "8.2 MiB") typically changes rapidly and, especially in the common "MiB" range, is very "jumpy" if the trailing digit is only shown if it's non-zero.
fmeum
force-pushed
the
improve-download-progress-format
branch
from
93b9a02
to
8b824c0
Compare
|
@coeuvre Sorry, forgot to update the tests. They are fixed now. |
sgowroji
added
the
team-Remote-Exec
sgowroji
removed
the
awaiting-PR-merge
|
@bazel-io fork 6.1.0 |
bazel-io
removed
the
potential release blocker
ShreeM01
added a commit
that referenced
this pull request
Jan 23, 2023
The human-readable download progress (e.g. "8.2 MiB") typically changes rapidly and, especially in the common "MiB" range, is very "jumpy" if the trailing digit is only shown if it's non-zero. Closes #16950. PiperOrigin-RevId: 493849764 Change-Id: I115923d572b35e304280499746d28a24df83c3f3 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The human-readable download progress (e.g. "8.2 MiB") typically changes rapidly and, especially in the common "MiB" range, is very "jumpy" if the trailing digit is only shown if it's non-zero.