Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(freebsd): use local JDK to build on FreeBSD #17185

Closed
wants to merge 2 commits into from
Closed

fix(freebsd): use local JDK to build on FreeBSD #17185

wants to merge 2 commits into from

Conversation

yesudeep
Copy link
Contributor

Attempt at addressing: #17184

@yesudeep
Copy link
Contributor Author

yesudeep commented Jan 10, 2023

The PR fixes the issue linked above, but other failures remain, and since there is no CI container image building for freebsd, I'm reporting it here.

This is with OpenJDK 18.0 and OpenJDK 11.0

ERROR: /usr/home/yesudeep/src/bazel/src/BUILD:188:8: Executing genrule //src:embedded_jdk_allmodules failed: (Exit 126): bash failed: error executing command (from target //src:embedded_jdk_allmodules) /usr/local/bin/bash -c ... (remaining 1 argument skipped)

Use --sandbox_debug to see verbose messages from the sandbox and retain the sandbox build root for debugging
src/minimize_jdk.sh: line 71: ./bin/jlink: cannot execute binary file: Exec format error
Target //src:bazel-dev failed to build
Use --verbose_failures to see the command lines of failed build steps.
INFO: Elapsed time: 1136.751s, Critical Path: 454.03s
INFO: 2270 processes: 94 internal, 1 local, 1364 processwrapper-sandbox, 811 worker.
FAILED: Build did NOT complete successfully

@ShreeM01 ShreeM01 added team-Rules-Java Issues for Java rules awaiting-review PR is awaiting review from an assigned reviewer labels Jan 10, 2023
FreeBSD users would need to build the bazel binary from
release distributions using OpenJDK 11 before they can hack on git HEAD.
@yesudeep
Copy link
Contributor Author

Ping.

@hvadehra
Copy link
Member

I think the better way forward would be to add remote_jdk repos for this platform in rules_java. There is some precedent for this, as long as we have a way to test this out. (see #11965 (comment))

@yesudeep is a VM for your OS+arch generally available?

@hvadehra hvadehra added awaiting-user-response Awaiting a response from the author P2 We'll consider working on this in future. (Assignee optional) and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 15, 2023
@yesudeep
Copy link
Contributor Author

yesudeep commented Oct 1, 2023

@hvadehra I'm afraid, a VM for the OS+arch isn't generally available at the moment.

@hvadehra
Copy link
Member

hvadehra commented Oct 4, 2023

In that case, I would say adding such declarations to bazel for everyone probably makes little sense.

@hvadehra hvadehra closed this Oct 4, 2023
@hvadehra hvadehra removed P2 We'll consider working on this in future. (Assignee optional) awaiting-user-response Awaiting a response from the author labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-Java Issues for Java rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants