Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stale workflow - process updates #17555

Closed
wants to merge 9 commits into from
Closed

Conversation

keertk
Copy link
Member

@keertk keertk commented Feb 22, 2023

No description provided.

@meteorcloudy meteorcloudy self-requested a review February 22, 2023 18:14
@keertk
Copy link
Member Author

keertk commented Feb 22, 2023

@sventiffe @radvani13 @oquenchil @Wyverald @alexeagle @keith @brentleyjones @fmeum

Hi all, we've made some updates to the stale workflow. Specifically,

  • We're going to start looking at all issues/PRs that are older than 3 years and close them out 14 days after a notification. Once this is complete, we'll move to more recent issues (2 years, 1 year, etc.) -- we're doing this in phases to avoid spamming and important notifications getting lost.
  • If authors feel that a particular issue/PR is still relevant, they can ping the triage team (@bazelbuild/triage) who will then reopen and/or tag the appropriate team lead to decide how to proceed - will this be worked on, is it in fact "not stale", etc.
  • All P0 and P1 labeled issues will be excluded from the stale workflow.

Please let us know if you have any comments or suggestions for improvement. We'll let the wider community know once we've finalized this process.

Thank you for your patience and support with this effort.

@keertk keertk marked this pull request as ready for review February 22, 2023 19:24
@keertk keertk added team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website awaiting-review PR is awaiting review from an assigned reviewer labels Feb 22, 2023
@keertk keertk changed the title GitHub actions process updates Stale workflow - process updates Feb 22, 2023
Copy link
Member

@meteorcloudy meteorcloudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 23, 2023
@alexeagle
Copy link
Contributor

I think this PR mistakes what was the problem: @sgowroji was marking issues stale (manually I guess) and then closing them at the same time, for example

#9429 (comment)

The stale.yml file gives reporters a chance to comment, both before and after this PR. I do agree with the changes here, but you should also make sure the team knows that the robot does this process, not humans.

@alexeagle
Copy link
Contributor

Also there's another problem not addressed in this PR.

After all those issues were closed, a few were re-opened because someone complained and got your attention. However there are probably many of them which are still valid issues representing bugs in Bazel, either because no one noticed when it was closed, they did notice but figured it's just "Bazel team doesn't care" so they didn't try to complain, or they did complain and no one noticed the comment so it stayed closed.

I think it would be nice to go back through the issues which were manually closed (not using the stale bot process) and evaluate what to do (maybe re-open them and let the stale bot do its thing)

For example @keith spent half a day filing issues which were all closed without anyone even looking at them.

@meteorcloudy
Copy link
Member

@alexeagle Yes, the team is now in sync that we'll use the stale bot to ping and close inactive issues and PRs, we won't close the issue without any notification first. There is a blog post on that going out very soon.

For the manually closed inacitve issues, I believe we did reopen all issues that got a reply. @keertk and @sgowroji can confirm that and perhaps provide the numbers of how many issues got closed and reopened.

@keertk keertk deleted the keertk-gh-process-updates branch March 14, 2023 01:03
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Closes bazelbuild#17555.

PiperOrigin-RevId: 512578345
Change-Id: I6fc3277410722d84ba57d2ae967d1aa9c6f0fdbb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants