-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stale workflow - process updates #17555
Conversation
@sventiffe @radvani13 @oquenchil @Wyverald @alexeagle @keith @brentleyjones @fmeum Hi all, we've made some updates to the stale workflow. Specifically,
Please let us know if you have any comments or suggestions for improvement. We'll let the wider community know once we've finalized this process. Thank you for your patience and support with this effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I think this PR mistakes what was the problem: @sgowroji was marking issues stale (manually I guess) and then closing them at the same time, for example The stale.yml file gives reporters a chance to comment, both before and after this PR. I do agree with the changes here, but you should also make sure the team knows that the robot does this process, not humans. |
Also there's another problem not addressed in this PR. After all those issues were closed, a few were re-opened because someone complained and got your attention. However there are probably many of them which are still valid issues representing bugs in Bazel, either because no one noticed when it was closed, they did notice but figured it's just "Bazel team doesn't care" so they didn't try to complain, or they did complain and no one noticed the comment so it stayed closed. I think it would be nice to go back through the issues which were manually closed (not using the stale bot process) and evaluate what to do (maybe re-open them and let the stale bot do its thing) For example @keith spent half a day filing issues which were all closed without anyone even looking at them. |
@alexeagle Yes, the team is now in sync that we'll use the stale bot to ping and close inactive issues and PRs, we won't close the issue without any notification first. There is a blog post on that going out very soon. For the manually closed inacitve issues, I believe we did reopen all issues that got a reply. @keertk and @sgowroji can confirm that and perhaps provide the numbers of how many issues got closed and reopened. |
Closes bazelbuild#17555. PiperOrigin-RevId: 512578345 Change-Id: I6fc3277410722d84ba57d2ae967d1aa9c6f0fdbb
No description provided.