Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove android_common jars from third_party #17582

Closed

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Feb 24, 2023

Working towards: #17036

After aaf94c6, we no longer need the checked-in android common jars under third_party directory.

@meteorcloudy
Copy link
Member Author

FYI @rjobredeaux3

@meteorcloudy
Copy link
Member Author

meteorcloudy commented Feb 24, 2023

@ahumesky The remaining third_party jars android tools depend on are:

bazel query "deps(//src/tools/android/java/com/google/devtools/build/android:all_android_tools)" | grep "\.jar$"
//third_party:apache_commons_codec/commons-codec-1.10.jar
//third_party:apache_commons_io/commons-io-2.4.jar
//third_party:asm/asm-9.2-sources.jar
//third_party:asm/asm-9.2.jar
//third_party:asm/asm-commons-9.2-sources.jar
//third_party:asm/asm-commons-9.2.jar
//third_party:asm/asm-tree-9.2-sources.jar
//third_party:asm/asm-tree-9.2.jar
//third_party:jsr330_inject/javax.inject.jar
//third_party/animal_sniffer:animal-sniffer-annotations-1.14.jar
//third_party/antlr:antlr4-4.5.3.jar
//third_party/java/android_databinding/v3_4_0:base.jar
//third_party/java/android_databinding/v3_4_0:compiler.jar
//third_party/java/android_databinding/v3_4_0:compiler_common.jar
//third_party/java/android_databinding/v3_4_0:exec.jar
//third_party/java/android_databinding/v3_4_0:x_common.jar
//third_party/java/jcommander:jcommander-1.48.jar
//third_party/jaxb:2.3.0/jaxb-api-2.3.0-sources.jar
//third_party/jaxb:2.3.0/jaxb-api-2.3.0.jar
//third_party/jaxb:2.3.0/jaxb-core-2.3.0-sources.jar
//third_party/jaxb:2.3.0/jaxb-core-2.3.0.jar
//third_party/jaxb:2.3.0/jaxb-impl-2.3.0-sources.jar
//third_party/jaxb:2.3.0/jaxb-impl-2.3.0.jar
//third_party/jetbrains_annotations:annotations-13.0.jar
//third_party/jetifier:jetifier-core-1.0.0-beta04.jar
//third_party/juniversalchardet:juniversalchardet-1.0.3.jar
//third_party/kotlin_stdlib:kotlin-stdlib-1.3.21.jar
//third_party/kotlin_stdlib:kotlin-stdlib-common-1.3.21.jar
//third_party/kotlin_stdlib:kotlin-stdlib-jdk7-1.3.21.jar
//third_party/kotlin_stdlib:kotlin-stdlib-jdk8-1.3.21.jar

I also tried to remove all those android_databinding jars and fetch them in maven_android_install, but it's hard for me to figure out what are the correct maven coordinates for those jars, can you help with that?

I believe this could also allow us to remove many other jars introduced as dependencies of android_databinding in #11629 and probably make it much easier to update the android databinding version as requested by #15804

@sgowroji sgowroji added team-Android Issues for Android team awaiting-review PR is awaiting review from an assigned reviewer labels Feb 24, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Feb 27, 2023
copybara-service bot pushed a commit that referenced this pull request Feb 27, 2023
Partial commit for third_party/*, see #17582.

Signed-off-by: Sunil Gowroji <sgowroji@google.com>
@sgowroji
Copy link
Member

Merged at 94d5d53

@sgowroji sgowroji closed this Feb 27, 2023
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Feb 27, 2023
fweikert pushed a commit to fweikert/bazel that referenced this pull request May 25, 2023
Partial commit for third_party/*, see bazelbuild#17582.

Signed-off-by: Sunil Gowroji <sgowroji@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Android Issues for Android team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants