Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

profile: add profile_finish_ts #17636

Closed

Commits on Apr 16, 2023

  1. profile: add profile_finish_ts

    "date" field in Bazel json profile is a confusing field.
    
    - It uses Java Date.toString() output which includes local timezone
      that could be hard to parse.
    
    - The name is misleading since users could mistook it for profile
      start time, while it actually means the finish/end time, when
      Bazel calls the writer to serialize profiling data to disk.
    
    Add "profile_finish_ts" which has a clearer name and more consistent
    value with the time unit being used in the rest of the JSON
    profile(microseconds).
    
    We shall deprecate the "date" field in a separate patch in a major
    release.
    sluongng committed Apr 16, 2023
    Configuration menu
    Copy the full SHA
    cbae4a4 View commit details
    Browse the repository at this point in the history