Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include symlinks and root_symlinks in Python ZIPs #17942

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Mar 31, 2023

Work towards #17941

@fmeum
Copy link
Collaborator Author

fmeum commented Mar 31, 2023

@rickeylev I couldn't find where and how to test this, could you give me some pointers?

@fmeum fmeum requested a review from rickeylev March 31, 2023 08:55
@fmeum fmeum force-pushed the 17941-python-zip-runfiles branch from 812eb37 to 2d71135 Compare March 31, 2023 08:57
@sgowroji sgowroji added team-Rules-Python Native rules for Python awaiting-review PR is awaiting review from an assigned reviewer labels Mar 31, 2023
@fmeum fmeum force-pushed the 17941-python-zip-runfiles branch from 2d71135 to d0dba4c Compare March 31, 2023 11:20
@rickeylev
Copy link
Contributor

Sorry, didn't see this till now.

Hm, I'm not sure. You want to verify the contents of a param file created when an action is run.

Try getting a handle on the PythonZipper action and looking at its inputs. Maybe the param file is in there. BuildViewTestCase.getGeneratingAction and ActionsTestUtil might help here.

Here's an example of how the regular template-expansion codepath has its action inspected: https://cs.opensource.google/bazel/bazel/+/master:src/test/java/com/google/devtools/build/lib/bazel/rules/python/BazelPyBinaryConfiguredTargetTest.java;l=76?q=f:test%20f:python%20getgeneratingaction&ss=bazel%2Fbazel:src%2F

Otherwise, I think there's a flag that makes params files persist after building; try that and then root around in bazel-out for the param file?

@rickeylev
Copy link
Contributor

LGTM, just needs tests.

@rickeylev rickeylev added awaiting-user-response Awaiting a response from the author and removed awaiting-review PR is awaiting review from an assigned reviewer labels May 14, 2023
Copy link

Thank you for contributing to the Bazel repository! This pull request has been marked as stale since it has not had any activity in the last 1+ years. It will be closed in the next 90 days unless any other activity occurs. If you think this PR is still relevant and should stay open, please post any comment here and the PR will no longer be marked as stale.

@github-actions github-actions bot added the stale Issues or PRs that are stale (no activity for 30 days) label Jan 20, 2025
@fmeum fmeum closed this Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-user-response Awaiting a response from the author stale Issues or PRs that are stale (no activity for 30 days) team-Rules-Python Native rules for Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants