-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch zlib to fix compatibility with Xcode 14.3 #17987
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meteorcloudy
changed the title
Patch zlib to fix compatibility with latest Xcode
Patch zlib to fix compatibility with Xcode 14.3
Apr 5, 2023
github-actions
bot
added
the
awaiting-review
PR is awaiting review from an assigned reviewer
label
Apr 5, 2023
Wyverald
approved these changes
Apr 5, 2023
Wyverald
added
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
and removed
awaiting-review
PR is awaiting review from an assigned reviewer
labels
Apr 5, 2023
keertk
added
the
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
label
Apr 5, 2023
hvadehra
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'm importing this one. |
keertk
removed
the
awaiting-PR-merge
PR has been approved by a reviewer and is ready to be merge internally
label
Apr 5, 2023
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 5, 2023
Fixes bazelbuild#17956 Partial commit for third_party/*, see bazelbuild#17987. Closes bazelbuild#17987 Signed-off-by: Yun Peng <pcloudy@google.com>
keertk
pushed a commit
that referenced
this pull request
Apr 5, 2023
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 5, 2023
Fixes bazelbuild#17956 Partial commit for third_party/*, see bazelbuild#17987. Closes bazelbuild#17987 Signed-off-by: Yun Peng <pcloudy@google.com>
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 11, 2023
Fixes bazelbuild#17956 Partial commit for third_party/*, see bazelbuild#17987. Closes bazelbuild#17987 Signed-off-by: Yun Peng <pcloudy@google.com>
ShreeM01
added a commit
that referenced
this pull request
Apr 11, 2023
ShreeM01
pushed a commit
to ShreeM01/bazel
that referenced
this pull request
Apr 11, 2023
Fixes bazelbuild#17956 Partial commit for third_party/*, see bazelbuild#17987. Closes bazelbuild#17987 Signed-off-by: Yun Peng <pcloudy@google.com>
keertk
pushed a commit
that referenced
this pull request
Apr 11, 2023
keertk
pushed a commit
that referenced
this pull request
Apr 12, 2023
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Fixes bazelbuild#17956 Partial commit for third_party/*, see bazelbuild#17987. Closes bazelbuild#17987 Signed-off-by: Yun Peng <pcloudy@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
team-OSS
Issues for the Bazel OSS team: installation, release processBazel packaging, website
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also storing the change as a separate patch file so that we know what to apply when upgrading zlib (if the problem isn't fixed already).
Fixes #17956