Don't eagerly flatten a NestedSet in RepoMappingManifestAction
#18349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
force-pushed
the
17941-no-flatten
branch
2 times, most recently
from
96fda7a
to
783a194
Compare
github-actions
bot
added
awaiting-review
fmeum
added
team-ExternalDeps
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark.
Wyverald
added
awaiting-PR-merge
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
|
@bazel-io fork 6.3.0 |
bazel-io
removed
the
potential release blocker
Pavank1992
removed
the
awaiting-PR-merge
rickeylev
reviewed
May 11, 2023
| ruleContext.getTransitivePackagesForRunfileRepoMappingManifest()), | ||
| runfiles), | ||
| ruleContext.getTransitivePackagesForRunfileRepoMappingManifest(), | ||
| runfiles.getAllArtifacts(), |
There was a problem hiding this comment.
FYI: getAllArtifacts() does a partial flattening -- symlinks and root symlinks are still flattened. But those those are usually small, so still a big win.
There was a problem hiding this comment.
Do you think it would be worth improving that further? Can Runfiles be serialized? Then that could make for a better action constructor argument.
There was a problem hiding this comment.
I think so? SourceManifestAction, for example, accepts a Runfiles object directly.
I wouldn't expect a large gain in practice. The symlinks and root_symlinks are usually small. Runfiles.getAllArtifacts() is called in a few different places already.
There was a problem hiding this comment.
Thanks for your comment, it led me to discover that the repo mapping manifest didn't handle symlinks correctly: #18381
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 16, 2023
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark. Work towards bazelbuild#17941 Closes bazelbuild#18349. PiperOrigin-RevId: 531165675 Change-Id: Ia2c175834d409c30303dd3ecba0dd276ea2cd905
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 16, 2023
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark. Work towards bazelbuild#17941 Closes bazelbuild#18349. PiperOrigin-RevId: 531165675 Change-Id: Ia2c175834d409c30303dd3ecba0dd276ea2cd905
fmeum
added a commit
to fmeum/bazel
that referenced
this pull request
May 19, 2023
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark. Work towards bazelbuild#17941 Closes bazelbuild#18349. PiperOrigin-RevId: 531165675 Change-Id: Ia2c175834d409c30303dd3ecba0dd276ea2cd905
fweikert
pushed a commit
to fweikert/bazel
that referenced
this pull request
May 25, 2023
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark. Work towards bazelbuild#17941 Closes bazelbuild#18349. PiperOrigin-RevId: 531165675 Change-Id: Ia2c175834d409c30303dd3ecba0dd276ea2cd905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Delays the flattening from action creation to action execution in preparation for making this action accessible from Starlark.
Work towards #17941