Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dangling string literal in extension_metadata docs #18587

Closed
wants to merge 1 commit into from
Closed

Fix dangling string literal in extension_metadata docs #18587

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jun 6, 2023

No description provided.

@fmeum
Copy link
Collaborator Author

fmeum commented Jun 6, 2023

@bazel-io flag

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jun 6, 2023
@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 6, 2023
@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jun 6, 2023
@meteorcloudy
Copy link
Member

@bazel-io fork 6.3.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jun 6, 2023
@bazel-io bazel-io mentioned this pull request Jun 6, 2023
Closed
@copybara-service copybara-service bot closed this in 5a89879 Jun 6, 2023
iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jun 6, 2023
@fmeum @iancha1992
Fix dangling string literal in extension_metadata docs
1da27f0 
Closes bazelbuild#18587.

PiperOrigin-RevId: 538171456
Change-Id: Idd8300c73beb60b101aaf28c4f04843051bae292
@iancha1992 iancha1992 mentioned this pull request Jun 6, 2023
Merged
@fmeum fmeum deleted the patch-1 branch June 6, 2023 20:00
@sgowroji sgowroji removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jun 7, 2023
iancha1992 added a commit that referenced this pull request Jun 7, 2023
@iancha1992 @fmeum
Fix dangling string literal in extension_metadata docs (#18598)
efb8928 
Closes #18587.

PiperOrigin-RevId: 538171456
Change-Id: Idd8300c73beb60b101aaf28c4f04843051bae292

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meteorcloudy meteorcloudy meteorcloudy approved these changes

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @meteorcloudy @bazel-io @sgowroji