Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.3.0] Rollforward of https://github.com/bazelbuild/bazel/commit/482d2be27ab… #18773

Merged
merged 3 commits into from
Jul 12, 2023

Commits on Jun 26, 2023

  1. Rollforward of bazelbuild@482d2be: Compute the value of plugin_output…

    … from proto_info
    
    NEW: don't try to compute plugin_output automatically
    
    Additional information is needed whether protoc generates a single file or multiple files.
    
    Add output_files to proto_lang_toolchain (enum "single","multiple") and propagate it through ProtoLangToolchainInfo.
    
    Add experimental_output_files to proto_common.compile, that can override the value, for faster migration path.
    
    When the value is set, automatically compute plugin_output.
    
    When the (legacy) plugin_output is not set to a file, set it automatically to correct directory.
    
    AI: Cherry-pick this change to Bazel minor release and follow up with updates to proto_lang_toolchain.
    
    Fixes: bazelbuild#18263
    Tracking issue: bazelbuild#18623
    PiperOrigin-RevId: 541964181
    Change-Id: Ie4b4792287723798ffdd4047562d62eb05d1b731
    comius committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    c73f70e View commit details
    Browse the repository at this point in the history
  2. Fix tests

    comius committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    8ca2bc0 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. Configuration menu
    Copy the full SHA
    a36ab04 View commit details
    Browse the repository at this point in the history