Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Operation stream termination is not an error #18785

Closed
wants to merge 1 commit into from
Closed

Operation stream termination is not an error #18785

wants to merge 1 commit into from

Commits on Jul 3, 2023

  1. Operation stream termination is not an error 

    According to the GrpcRemoteExecutor when it occurs after a !done
operation response. Remove the error from the
ExperimentalRemoteGrpcExecutor and reinforce both with tests.

Update the FakeExecutionService to generate compatible error responses
that appear in the ExecuteResponse, rather than the operation error
field, per the REAPI spec. Made required adjustments to ExGRE Test
invocations to avoid the ExecutionStatusException interpretation of
DEADLINE_EXCEEDED -> FAILED_PRECONDITION in ExecuteResponse.
    @werkt
    werkt committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    0248fcb View commit details
    Browse the repository at this point in the history