Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flip --incompatible_hermetic_sandbox_tmp for Bazel #18892

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 11, 2023

Fixes spurious Java compile action failures when the action is sandboxed.

Work towards #3236

@fmeum fmeum requested a review from larsrc-google July 11, 2023 09:26
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 11, 2023

@larsrc-google This is motivated by #18685 (comment) and preparation for flipping the flag globally. Do you think we could flip it for Bazel 7?

CC @lberki

Fixes spurious Java compile action failures when the action is
sandboxed.

Work towards bazelbuild#3236
@sgowroji sgowroji added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Jul 11, 2023
@meisterT meisterT requested a review from wilwell July 13, 2023 11:22
@meisterT
Copy link
Member

I think this is a good idea - it will give us a data point whether we can flip it in general.

@Pavank1992
Copy link
Contributor

Hi @meisterT, as this PR is approved, please suggest if it is ready for import?

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Jul 28, 2023
@fmeum fmeum deleted the 3236-flip-for-bazel branch July 28, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants