Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.3.0] Adjust --top_level_targets_for_symlinks #18916

Merged
merged 2 commits into from
Jul 12, 2023
Merged

[6.3.0] Adjust --top_level_targets_for_symlinks #18916

merged 2 commits into from
Jul 12, 2023

Commits on Jul 12, 2023

  1. Adjust --top_level_targets_for_symlinks 

    Adjust `--top_level_targets_for_symlinks`.

- If all targets in `$ bazel build //...` have the top-level config, `bazel-bin`, etc. point to that config
- If all targets in `$ bazel build //...` have the same transitioned config, `bazel-bin`, etc. point to that config
- If targets in `$ bazel build //...` have mixed configs, `bazel-bin`, etc. are deleted

- If all targets in `$ bazel build //...` have the top-level config, `bazel-bin`, etc. point to that config
- If all targets in `$ bazel build //...` have the same transitioned config, `bazel-bin`, etc. point to that config
- If targets in `$ bazel build //...` have mixed configs and at least one of them is the top-level config, `bazel-bin`, etc. point to the top-level config
- If targets in `$ bazel build //...` have mixed configs and none are the top-level config, `bazel-bin`, etc. are deleted

Fixes bazelbuild#17081.

Closes bazelbuild#18854.

PiperOrigin-RevId: 546938509
Change-Id: I75adf0b8c2094522125c5e65d8c450eb2436d392
    @gregestren
    gregestren committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    856662a View commit details
    Browse the repository at this point in the history

  2. Merge with 6.3.0 baseline. 

    Particularly manually merge relevant signature changes from
bazelbuild@1cd3588. Thsi
is different than
bazelbuild@1cd3588
itself because that also uses a baseline too new for 6.3.0.
    @gregestren
    gregestren committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    069a50c View commit details
    Browse the repository at this point in the history