Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge use_repo buildifier fixups into a single command #19119

Closed
wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Jul 28, 2023

Users only have to copy&paste a single command this way.

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Jul 28, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 28, 2023

Thanks @alexeagle for making me aware of this Buildozer syntax.

Users only have to copy&paste a single command this way.
@fmeum fmeum force-pushed the shorter-buildozer-commands branch from b1e4e19 to 26da012 Compare July 28, 2023 15:52
@fmeum
Copy link
Collaborator Author

fmeum commented Jul 28, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 28, 2023
@Wyverald
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Jul 28, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 28, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 28, 2023
@fmeum fmeum deleted the shorter-buildozer-commands branch July 29, 2023 20:13
@meteorcloudy
Copy link
Member

It's probably worth adding a section about managing use_repo with buildifier at https://bazel.build/external/migration#best-practices

iancha1992 pushed a commit to iancha1992/bazel that referenced this pull request Jul 31, 2023
Users only have to copy&paste a single command this way.

Closes bazelbuild#19119.

PiperOrigin-RevId: 551887901
Change-Id: Id285563e83a18ac9a4db3b2d4e8d731d5b3f5813
iancha1992 added a commit that referenced this pull request Jul 31, 2023
Users only have to copy&paste a single command this way.

Closes #19119.

PiperOrigin-RevId: 551887901
Change-Id: Id285563e83a18ac9a4db3b2d4e8d731d5b3f5813

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@keertk
Copy link
Member

keertk commented Sep 21, 2023

The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants