Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update platforms #19133

Closed
wants to merge 1 commit into from
Closed

Update platforms #19133

wants to merge 1 commit into from

Conversation

keith
Copy link
Member

@keith keith commented Jul 31, 2023

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Android Issues for Android team labels Jul 31, 2023
ted-xie
ted-xie approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@ted-xie ted-xie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The Android-related bzlmod test should probably be refactored in such a way that it doesn't have a hard dependence on @platforms; that will be future work.

@ted-xie ted-xie added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Aug 2, 2023
@copybara-service copybara-service bot closed this in 7ed631e Aug 2, 2023
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Aug 2, 2023
@keith keith deleted the ks/update-platforms branch August 2, 2023 22:35
@keith
Copy link
Member Author

keith commented Aug 2, 2023

thanks!

@brentleyjones
Copy link
Contributor

We can probably cherry-pick this into 6.4.0, right?

@keith keith mentioned this pull request Aug 3, 2023
Closed
@keith
Copy link
Member Author

keith commented Aug 3, 2023

Probably only useful if you hope to cherry pick visionOS support too

@keith
Copy link
Member Author

keith commented Aug 3, 2023

for future reference i missed 2 test-specific version bumps, i added them to #18905

@keith keith mentioned this pull request Sep 6, 2023
Merged
keith added a commit to keith/bazel that referenced this pull request Sep 6, 2023
@keith
[6.4.0] Add visionOS support
8e28723 
This cherry picks bazelbuild#18905 and bazelbuild#19133
keith added a commit to keith/bazel that referenced this pull request Sep 8, 2023
@keith
[6.4.0] Add visionOS support
e779353 
This cherry picks bazelbuild#18905 and bazelbuild#19133
keith added a commit to keith/bazel that referenced this pull request Sep 8, 2023
@keith
[6.4.0] Add visionOS support
e63dfe7 
This cherry picks bazelbuild#18905 and bazelbuild#19133
iancha1992 pushed a commit that referenced this pull request Sep 11, 2023
@keith @nglevin
[6.4.0] Add visionOS support (#19436)
fb4cc46 
This cherry picks #18905 and
#19133

Co-authored-by: nglevin <122120823+nglevin@users.noreply.github.com>
@iancha1992
Copy link
Member

The changes in this PR have been included in Bazel 6.4.0 RC1. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ted-xie ted-xie ted-xie approved these changes

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky is a code owner

Assignees
No one assigned
Labels
team-Android Issues for Android team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@keith @brentleyjones @iancha1992 @ted-xie