Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the obsolete exec_tools attribute from genrule. #19142

Closed
wants to merge 1 commit into from
Closed

Remove the obsolete exec_tools attribute from genrule. #19142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions src/main/java/com/google/devtools/build/lib/bazel/rules/genrule/BazelGenRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,14 +31,4 @@ protected boolean isStampingEnabled(RuleContext ruleContext) {
}
return ruleContext.attributes().get("stamp", Type.BOOLEAN);
}

// TODO(https://github.com/bazelbuild/bazel/issues/19132): Remove this override once downstream
// projects are migrated.
@Override
protected CommandHelper.Builder commandHelperBuilder(RuleContext ruleContext) {
return CommandHelper.builder(ruleContext)
.addToolDependencies("tools")
.addToolDependencies("exec_tools")
.addToolDependencies("toolchains");
}
}
17 changes: 0 additions & 17 deletions src/main/java/com/google/devtools/build/lib/bazel/rules/genrule/BazelGenRuleRule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,23 +46,6 @@ public RuleClass build(RuleClass.Builder builder, RuleDefinitionEnvironment env)
.cfg(ExecutionTransitionFactory.createFactory())
.value(env.getToolsLabel(GENRULE_SETUP_LABEL)))

// TODO(https://github.com/bazelbuild/bazel/issues/19132): Remove this once downstream
// projects are migrated.
/* <!-- #BLAZE_RULE(genrule).ATTRIBUTE(exec_tools) -->
<b>Deprecated. Use <a href="#genrule.tools"><code>tools</code></a> instead.</b>

<p>
There was a period of time when <code>exec_tools</code> and <code>tools</code> behaved
differently, but they are now equivalent and the Blaze team will be migrating all uses of
<code>exec_tools</code> to <code>tools</code>.
</p>
<!-- #END_BLAZE_RULE.ATTRIBUTE --> */
.add(
attr("exec_tools", LABEL_LIST)
.cfg(ExecutionTransitionFactory.createFactory())
.allowedFileTypes(FileTypeSet.ANY_FILE)
.dontCheckConstraints())

// TODO(bazel-team): stamping doesn't seem to work. Fix it or remove attribute.
.add(attr("stamp", BOOLEAN).value(false))
.build();
Expand Down