Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use effective StarlarkSemantics with cquery --output=starlark #19334

Closed
wants to merge 1 commit into from
Closed

Use effective StarlarkSemantics with cquery --output=starlark #19334

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Aug 25, 2023 •
edited
Loading

Previously, BuildLanguageOptions had no effect as the default semantics were used.

Work towards #17864

@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-Configurability platforms, toolchains, cquery, select(), config transitions team-Performance Issues for Performance teams labels Aug 25, 2023
@fmeum fmeum requested a review from aranguyen August 25, 2023 11:10
@fmeum fmeum removed the team-Performance Issues for Performance teams label Aug 25, 2023
@fmeum fmeum requested review from gregestren and removed request for aranguyen September 13, 2023 10:20
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 13, 2023

@gregestren This is meant to prepare for #17864 (comment), which will provide a way to align {a,c}query output with that of str(Label(...)) in Starlark.

CC @Wyverald

@fmeum fmeum force-pushed the 17864-cquery-starlark-semantics branch from 42bbe42 to 4886b3e Compare September 13, 2023 10:48
@fmeum
Use effective StarlarkSemantics with cquery --output=starlark
080593a 
Previously, `BuildLanguageOption`s had no effect as the default
semantics were used.
@fmeum fmeum force-pushed the 17864-cquery-starlark-semantics branch from 4886b3e to 080593a Compare September 17, 2023 13:18
@fmeum fmeum requested a review from Wyverald September 17, 2023 13:18
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 17, 2023

@bazel-io flag

@fmeum
Copy link
Collaborator Author

fmeum commented Sep 17, 2023

I added a test.

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 17, 2023
Wyverald
Wyverald approved these changes Sep 17, 2023
View reviewed changes
Copy link
Member

@Wyverald Wyverald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix!

@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 17, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 18, 2023
@bazel-io bazel-io mentioned this pull request Sep 18, 2023
Closed
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 19, 2023
Wyverald pushed a commit that referenced this pull request Sep 19, 2023
@fmeum @Wyverald
[6.4.0] Use effective StarlarkSemantics with `cquery --output=starl…
1ebd6a9 
…ark`

Previously, `BuildLanguageOption`s had no effect as the default semantics were used.

Work towards #17864

Closes #19334.

PiperOrigin-RevId: 566747820
Change-Id: I5071f97c68e02808ea8183b9c52c89a2e8e39620
@fmeum fmeum deleted the 17864-cquery-starlark-semantics branch September 19, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

@gregestren gregestren Awaiting requested review from gregestren

Assignees
No one assigned
Labels
team-Configurability platforms, toolchains, cquery, select(), config transitions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fmeum @iancha1992 @Wyverald @bazel-io