Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain the use of str(Label(...)) in the docs #19509

Closed
wants to merge 1 commit into from
Closed

Explain the use of str(Label(...)) in the docs #19509

wants to merge 1 commit into from

Conversation

fmeum
Copy link
Collaborator

@fmeum fmeum commented Sep 13, 2023

No description provided.

@fmeum fmeum requested a review from Wyverald September 13, 2023 12:40
@github-actions github-actions bot added the awaiting-review PR is awaiting review from an assigned reviewer label Sep 13, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 13, 2023

@Wyverald I guess we are technically lying here as long as we don't declare repo mappings broken with --noenable_bzlmod, but I felt that's okay.

@sgowroji sgowroji added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Sep 14, 2023
@Wyverald Wyverald added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 14, 2023
@fmeum fmeum deleted the label-docs branch September 15, 2023 20:28
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Sep 15, 2023
@fmeum
Copy link
Collaborator Author

fmeum commented Sep 15, 2023

@bazel-io flag

@bazel-io bazel-io added the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 15, 2023
@iancha1992
Copy link
Member

@bazel-io fork 6.4.0

@bazel-io bazel-io removed the potential release blocker Flagged by community members using "@bazel-io flag". Should be added to a release blocker milestone label Sep 18, 2023
This was referenced Sep 18, 2023
Closed
Merged
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request Sep 18, 2023
@fmeum @bazel-io
Explain the use of str(Label(...)) in the docs
a2ee2e0 
Closes bazelbuild#19509.

PiperOrigin-RevId: 565763282
Change-Id: I0a8ede20b6bda5140a83c03a44577c034a54dd5f
iancha1992 pushed a commit that referenced this pull request Sep 18, 2023
@bazel-io @fmeum
[6.4.0] Explain the use of str(Label(...)) in the docs (#19554)
ec8c12d 
Closes #19509.

Commit
d9beda5

PiperOrigin-RevId: 565763282
Change-Id: I0a8ede20b6bda5140a83c03a44577c034a54dd5f

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Wyverald approved these changes

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fmeum @iancha1992 @Wyverald @bazel-io @sgowroji