Remove stale extension entries from lockfile #19658
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When changes to module files result in module resolution rerunning, extension results from the lockfile may become stale due to changed usages even if the current build doesn't evaluate the affected extension. We now compare the current usages against the usages recorded in the lockfile and drop all extensions that became stale. Along the way, also trim tag locations when comparing usages for staleness detections as they do not affect the evaluation result.
github-actions
bot
added
awaiting-review
|
@bazel-io flag |
bazel-io
added
the
potential release blocker
SalmaSamy
approved these changes
Sep 28, 2023
meteorcloudy
added
awaiting-PR-merge
|
@bazel-io fork 6.4.0 |
bazel-io
removed
the
potential release blocker
github-actions
bot
removed
the
awaiting-PR-merge
bazel-io
pushed a commit
to bazel-io/bazel
that referenced
this pull request
Sep 29, 2023
When changes to module files result in module resolution rerunning, extension results from the lockfile may become stale due to changed usages even if the current build doesn't evaluate the affected extension. We now compare the current usages against the usages recorded in the lockfile and drop all extensions that became stale. Along the way, also trim tag locations when comparing usages for staleness detections as they do not affect the evaluation result. Closes bazelbuild#19658. PiperOrigin-RevId: 569612685 Change-Id: I8e9e30c37076ef2cbfa6e0498b9e003a078e4c67
iancha1992
pushed a commit
that referenced
this pull request
Oct 2, 2023
When changes to module files result in module resolution rerunning, extension results from the lockfile may become stale due to changed usages even if the current build doesn't evaluate the affected extension. We now compare the current usages against the usages recorded in the lockfile and drop all extensions that became stale. Along the way, also trim tag locations when comparing usages for staleness detections as they do not affect the evaluation result. Closes #19658. Commit 9bf8f39 PiperOrigin-RevId: 569612685 Change-Id: I8e9e30c37076ef2cbfa6e0498b9e003a078e4c67 Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
|
The changes in this PR have been included in Bazel 6.4.0 RC2. Please test out the release candidate and report any issues as soon as possible. If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=last_rc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When changes to module files result in module resolution rerunning, extension results from the lockfile may become stale due to changed usages even if the current build doesn't evaluate the affected extension.
We now compare the current usages against the usages recorded in the lockfile and drop all extensions that became stale.
Along the way, also trim tag locations when comparing usages for staleness detections as they do not affect the evaluation result.