Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip --enable_bzlmod #19699

Closed
wants to merge 44 commits into from
Closed

Flip --enable_bzlmod #19699

wants to merge 44 commits into from

Conversation

meteorcloudy
Copy link
Member

@meteorcloudy meteorcloudy commented Oct 2, 2023 •
edited
Loading

Fixes #18958

@meteorcloudy meteorcloudy marked this pull request as draft October 2, 2023 12:27
@github-actions github-actions bot added awaiting-review PR is awaiting review from an assigned reviewer team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. labels Oct 2, 2023
@meteorcloudy meteorcloudy force-pushed the flip_bzlmod branch 12 times, most recently from cd5622b to 9a913db Compare October 8, 2023 13:09
@meteorcloudy
Flip --enable_bzlmod
e93e6cf
@meteorcloudy
Disable Bzlmod in all failing tests
0bd2f15 
Disable bzlmod for BuildViewTestCase

Disable --enable_bzlmod by default for AnalysisTestCase

Disable bzlmod in BuildIntegrationTestCase

Disable bzlmod in more tests

Flip bzlmod in BuildLanguageOptions

Disable bzlmod in more tests

Make more tests green

Make more tests green

Disable bzlmod in more tests

Fix more tests

Fix bzlmod tests

Fix package loader tests
@meteorcloudy
Only run on Linux
fbccb02
@meteorcloudy
Setup AnalysisMock for Bzlmod
38f08f4
@meteorcloudy
Disable bzlmod for //src/test/java/com/google/devtools/build/lib/baze…
6859bed 
…l/rules/android:AndroidTests
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/bazel/repository/st…
a940da3 
…arlark:StarlarkTests
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/analysis:StarlarkSu…
958d788 
…bruleTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/exec:ExecTests
fafcb90
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules:rules_tests
a340c02
@meteorcloudy
Disable Bzlmod to fix //src/test/java/com/google/devtools/build/lib/r…
f98251a 
…ules/config:ConfigRulesTests
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules/cpp:CcBadDe…
0e8a2e5 
…pendenciesTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules/cpp:CcCommo…
52c4a99 
…nTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules/cpp:CcLibra…
96866ff 
…ryConfiguredTargetTest
@meteorcloudy
Setup rules_proto mock for Bzlmod to fix //src/test/java/com/google/d…
3be19fc 
…evtools/build/lib/rules/objc:BazelJ2ObjcLibraryTest
@meteorcloudy
Fix //src/test/java/com/google/devtools/build/lib/starlark:StarlarkTests
5ecc9e7
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/exec:ExecTests
f7ce7f8
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules:rules_tests
0b7b17a
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/query2/cquery:Tra…
e4d3705 
…nsitionsOutputFormatterTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules/android:And…
d0a5ec5 
…roidLibraryTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/rules/android:And…
189e365 
…roidLibraryTest
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/query2/engine:All…
d2c1250 
…Tests
@meteorcloudy
Make both //src/test/java/com/google/devtools/build/lib/query2/engine…
cf8bac7 
…:AllTests and //src/test/java/com/google/devtools/build/lib/query2/cquery:TransitionsOutputFormatterTest green
@meteorcloudy
Fixes //src/test/java/com/google/devtools/build/lib/analysis:Analysis…
9c81069 
…Tests
@meteorcloudy
Try enable bzlmod for python integration tests
966d26f
@meteorcloudy
Fixes //src/test/py/bazel:bazel_workspace_test
bbdcca9
@meteorcloudy
Fixes //src/test/py/bazel:runfiles_test
66afb65
@meteorcloudy
Fixes //src/test/py/bazel:launcher_test
dc3d017
@meteorcloudy
Fixes //src/test/py/bazel:py_test
c102a71
@meteorcloudy
Fixes //src/test/py/bazel:runfiles_sandboxed_test
1619028
@meteorcloudy
Use a default lock file for python integration tests to avoid accessi…
1b1377f 
…ng BCR
@meteorcloudy meteorcloudy changed the title Allow no MODULE.bazel and flip --enable_bzlmod Flip --enable_bzlmod Oct 10, 2023
@meteorcloudy
Copy link
Member Author

Replaced by #19817

@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Oct 14, 2023
@davido davido mentioned this pull request Nov 18, 2023
Closed
@Wyverald Wyverald deleted the flip_bzlmod branch July 31, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wyverald Wyverald Awaiting requested review from Wyverald Wyverald is a code owner

@oquenchil oquenchil Awaiting requested review from oquenchil oquenchil will be requested when the pull request is marked ready for review oquenchil is a code owner

@ahumesky ahumesky Awaiting requested review from ahumesky ahumesky will be requested when the pull request is marked ready for review ahumesky is a code owner

@ted-xie ted-xie Awaiting requested review from ted-xie ted-xie will be requested when the pull request is marked ready for review ted-xie is a code owner

Assignees
No one assigned
Labels
team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

enable_bzlmod: Flip the default value of --enable_bzlmod to true
1 participant
@meteorcloudy