Use URLs as default canonical IDs in common repo rules #20128
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RELNOTES[INC]: The `--experimental_repository_cache_urls_as_default_canonical_id` flag is no longer available. Instead, the `http_archive`, `http_file`, `http_jar`, `jvm_maven_import_external`, and `jvm_import_external` repository rules now use the URLs as the canonical ID if none is provided explicitly. If this behavior is not desired, it can be disabled via `--repo_env=BAZEL_HTTP_RULES_URLS_AS_DEFAULT_CANONICAL_ID=0`. Fixes bazelbuild#19749 Closes bazelbuild#20047. PiperOrigin-RevId: 580826938 Change-Id: I32bfb04084ce75b74f664794e1924d3188f58805
fmeum
force-pushed
the
release-7.0.0-url
branch
from
99bf3ee
to
0ac10e0
Compare
github-actions
bot
added
awaiting-review
|
@keertk This merge conflict was purely due to |
|
Good to know, thanks @fmeum! Makes sense to add this to the workflow. |
|
Good idea, when should resolve it during cherry-pick. |
|
Thank you both. Just created #20147 since we needed to fix this again. Closing this one. |
auto-merge was automatically disabled
November 10, 2023 20:01
Pull request was closed
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELNOTES[INC]: The
--experimental_repository_cache_urls_as_default_canonical_idflag is no longer available. Instead, thehttp_archive,http_file,http_jar,jvm_maven_import_external, andjvm_import_externalrepository rules now use the URLs as the canonical ID if none is provided explicitly. If this behavior is not desired, it can be disabled via--repo_env=BAZEL_HTTP_RULES_URLS_AS_DEFAULT_CANONICAL_ID=0.Fixes #19749
Closes #20047.
PiperOrigin-RevId: 580826938
Change-Id: I32bfb04084ce75b74f664794e1924d3188f58805
Closes #19990