Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0.0] Enable --incompatible_sandbox_hermetic_tmp by default #20136

Merged
merged 2 commits into from
Nov 10, 2023

Conversation

bazel-io
Copy link
Member

Fixes #3236
Closes #19915

RELNOTES[INC]: --incompatible_sandbox_hermetic_tmp is enabled by default. See #19915 for migration advice.

Closes #19943.

Commit e2c0276

PiperOrigin-RevId: 581165770
Change-Id: I0d98102f10b1e47c1d8fcf32fb1f7dee5ae0788c

Fixes bazelbuild#3236
Closes bazelbuild#19915

RELNOTES[INC]: `--incompatible_sandbox_hermetic_tmp` is enabled by default. See bazelbuild#19915 for migration advice.

Closes bazelbuild#19943.

PiperOrigin-RevId: 581165770
Change-Id: I0d98102f10b1e47c1d8fcf32fb1f7dee5ae0788c
@bazel-io bazel-io requested a review from a team as a code owner November 10, 2023 09:50
@bazel-io bazel-io added team-Local-Exec Issues and PRs for the Execution (Local) team awaiting-review PR is awaiting review from an assigned reviewer labels Nov 10, 2023
@bazel-io bazel-io requested a review from lberki November 10, 2023 09:50
@keertk
Copy link
Member

keertk commented Nov 10, 2023

Hey @fmeum mind submitting a PR against release-7.0.0 for this?
Or let me know what needs to be changed to fix the failures.

@fmeum
Copy link
Collaborator

fmeum commented Nov 10, 2023

@keertk I think that you only need to also cherry-pick 491284b. If that's not enough, please mention me again.

@keertk
Copy link
Member

keertk commented Nov 10, 2023

Ok, cherry-picked here: #20145

@keertk keertk merged commit fe85936 into bazelbuild:release-7.0.0 Nov 10, 2023
31 checks passed
@github-actions github-actions bot removed the awaiting-review PR is awaiting review from an assigned reviewer label Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Local-Exec Issues and PRs for the Execution (Local) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants